devscope.io

chore: Update Griffel to latest version

microsoft/fluentui

Issue

New Behavior

Bumps Griffel packages to latest versions to get https://github.com/microsoft/griffel/pull/207. Because of that fix there is a visual regression in SpinButton that works now correctly (described in https://github.com/microsoft/griffel/issues/204).

2022-10-04 15:55:14


Add a Comment


Top 3 Comments

  fabricteam answered on 2022-10-04 16:11:56

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 1292 1304 5000
Button mount 938 927 5000
FluentProvider mount 1494 1471 5000
FluentProviderWithTheme mount 593 568 10
FluentProviderWithTheme virtual-rerender 540 542 10
FluentProviderWithTheme virtual-rerender-with-unmount 579 572 10
MakeStyles mount 2024 2029 50000
SpinButton mount 2409 2350 5000

0 positive reactions.
  size-auditor[bot] answered on 2022-10-04 16:09:44

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: b4a703103ebdf240bdce2fd629d8e5783ebb6ad1 (build)

0 positive reactions.
  codesandbox-ci[bot] answered on 2022-10-04 16:07:47

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 626770c6a8deff02c95256da6eaa5d09be9ec731:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration
0 positive reactions.

Quick Hint

Is Microsoft Publisher still available?

Publisher 2019 is the latest single purchase version of Publisher available to consumers. You'll find Publisher on sale at the US Microsoft Store online only for US$129.99.Oct 30, 2019

Repo Information


Age 6yrs
Vendor microsoft
Repo Name fluentui
Primary Language TypeScript
Default Branch master
Last Update 14 hours ago

Microsoft's Code Library

Similar Issues

πŸ’Ύ DirectXShaderCompiler Update Linux build and test workflows to use lit πŸ’¬ 3 open πŸ—“οΈ 16 hours ago
πŸ’Ύ DirectXShaderCompiler DXC API fails to report compilation error πŸ’¬ 3 closed πŸ—“οΈ 1 day ago
πŸ’Ύ DirectXShaderCompiler [NFC] Address some low hanging fruit UBSan failures πŸ’¬ 5 open πŸ—“οΈ 1 day ago
πŸ’Ύ AzureTRE Amend conda configuration in Nexus πŸ’¬ 3 open πŸ—“οΈ 2 days ago
πŸ’Ύ AzureTRE Firewall policies and Ip group πŸ’¬ 3 open πŸ—“οΈ 2 days ago
πŸ’Ύ AzureTRE Remove links from quickstart πŸ’¬ 3 closed πŸ—“οΈ 2 days ago