devscope.io

Bind object type literals in JSDoc

microsoft/TypeScript

Issue

Object type literals are a specific instance of types that really need to have their own symbol table for language service operations.

We could try binding everything from JSDoc, but that does "extra" work like declaring types from JSDoc, which is undesirable. Instead, this PR just adds a lightweight walk to perform local binding within type literals in JSDoc, rather than parameterizing bindWorker.

It might be the case that we have to account for function types, constructor types, and mapped types, which all implicitly create their own symbol tables, and that might be fine too.

Fixes #51054 Alternative fix for #50750 Ref #51057, #51055

CC @a-tarasyuk who's been working on these issues.

2022-10-04 23:41:05


Add a Comment


Top 3 Comments

  typescript-bot answered on 2022-10-04 23:46:54

Heya @DanielRosenwasser, I've started to run the diff-based user code test suite (tsserver) on this PR at 1d901bfa82f7f166ee3779f8541741d6a25dc52d. You can monitor the build here.

Update: The results are in!

0 positive reactions.
  typescript-bot answered on 2022-10-04 23:46:54

Heya @DanielRosenwasser, I've started to run the diff-based top-repos suite (tsserver) on this PR at 1d901bfa82f7f166ee3779f8541741d6a25dc52d. You can monitor the build here.

Update: The results are in!

0 positive reactions.
  DanielRosenwasser answered on 2022-10-04 23:46:50

@typescript-bot run dt slower @typescript-bot perf test this faster @typescript-bot user test tsserver @typescript-bot test tsserver top100

0 positive reactions.

Quick Hint

What version of TypeScript does Angular 8 use?

Angular 8 supports the TypeScript 3.4 or above version. So, if we want to use Angular 8 for our application, then we need to first upgrade the TypeScript to 3.4 or above.

Repo Information


Age 8yrs
Vendor microsoft
Repo Name TypeScript
Primary Language TypeScript
Default Branch main
Last Update 8 hours ago

Microsoft's Code Library

Similar Issues

πŸ’Ύ DirectXShaderCompiler Update Linux build and test workflows to use lit πŸ’¬ 3 open πŸ—“οΈ 15 hours ago
πŸ’Ύ DirectXShaderCompiler DXC API fails to report compilation error πŸ’¬ 3 closed πŸ—“οΈ 1 day ago
πŸ’Ύ vue-styleguidist fix(deps): update typescript-eslint monorepo to v5.45.0 πŸ’¬ 5 closed πŸ—“οΈ 1 day ago
πŸ’Ύ DirectXShaderCompiler [NFC] Address some low hanging fruit UBSan failures πŸ’¬ 5 open πŸ—“οΈ 1 day ago
πŸ’Ύ hash Update TypeScript to 4.9 πŸ’¬ 4 closed πŸ—“οΈ 1 day ago
πŸ’Ύ AzureTRE Amend conda configuration in Nexus πŸ’¬ 3 open πŸ—“οΈ 2 days ago
πŸ’Ύ AzureTRE Firewall policies and Ip group πŸ’¬ 3 open πŸ—“οΈ 2 days ago