devscope.io

:bug: Remove the logical-cluster & sync-target labels from syncer namespace

kcp-dev/kcp

Issue

Summary

Removing the following labels from the Namespace yaml definition generated while performing a workload sync operation:

labels:
    workload.kcp.io/logical-cluster: {{.LabelSafeLogicalCluster}}
    workload.kcp.io/sync-target: {{.SyncTarget}}

Fixes #1843

2022-10-04 18:52:06


Add a Comment


Top 3 Comments

  ncdc answered on 2022-10-04 18:54:53

/ok-to-test /approve

0 positive reactions.
  ncdc answered on 2022-10-04 18:54:46

I think you can also remove LabelSafeLogicalCluster from templateArgs?

1 positive reactions.
  openshift-ci[bot] answered on 2022-10-04 18:52:18

Hi @apoorvajagtap. Thanks for your PR.

I'm waiting for a kcp-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
0 positive reactions.

Repo Information


Age 1yr
Vendor kcp-dev
Repo Name kcp
Primary Language Go
Default Branch main
Last Update 15 hours ago

Similar Issues

πŸ’Ύ kcp :sparkles: Front proxy user gating πŸ’¬ 3 open πŸ—“οΈ 3 weeks ago
πŸ’Ύ kcp :seedling: test-server: split New/Start/Ready phases πŸ’¬ 8 open πŸ—“οΈ 4 weeks ago
πŸ’Ύ kcp :bug: Clean up shadow CRDs after API bindings are deleted πŸ’¬ 3 open πŸ—“οΈ 4 weeks ago
πŸ’Ύ kcp :seedling: sharded-test-server: consistently use workDirPath πŸ’¬ 3 closed πŸ—“οΈ 4 weeks ago
πŸ’Ύ kcp πŸ› Fix: watch a certain synctarget only πŸ’¬ 4 closed πŸ—“οΈ 1 month ago
πŸ’Ύ kcp :sparkles: one DNS nameserver per workspace πŸ’¬ 3 open πŸ—“οΈ 1 month ago