devscope.io

πŸ› Fix kubectl overrides in 'kubectl workspace' plugin commands

kcp-dev/kcp

Issue

Summary

Fix kubectl override flags such as --token in the workspace plugin commands.

Related issue(s)

Fixes #2057

2022-09-22 19:50:05


Add a Comment


Top 3 Comments

  openshift-ci[bot] answered on 2022-09-22 20:07:06

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stevekuznetsov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[pkg/cliplugins/OWNERS](https://github.com/kcp-dev/kcp/blob/main/pkg/cliplugins/OWNERS)~~ [stevekuznetsov] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
0 positive reactions.
  openshift-cherrypick-robot answered on 2022-09-22 19:50:40

@ncdc: once the present PR merges, I will cherry-pick it on top of release-0.8 in a new PR and assign it to you.

In response to [this](https://github.com/kcp-dev/kcp/pull/2058#issuecomment-1255479342): >/cherry-pick release-0.8 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
0 positive reactions.
  ncdc answered on 2022-09-22 19:50:38

/cherry-pick release-0.8

0 positive reactions.

Repo Information


Age 1yr
Vendor kcp-dev
Repo Name kcp
Primary Language Go
Default Branch main
Last Update 1 day ago

Similar Issues

πŸ’Ύ kcp :bug: Removes the logical-cluster & sync-target labels from syncer namespace πŸ’¬ 4 open πŸ—“οΈ 19 hours ago
πŸ’Ύ kcp Community Meeting October 4, 2022 πŸ’¬ 4 open πŸ—“οΈ 23 hours ago
πŸ’Ύ kcp feature: privileged annotations and labels for API providers πŸ’¬ 3 open πŸ—“οΈ 1 day ago
πŸ’Ύ kcp :book: update docs and docs-gen according to hugo syntax πŸ’¬ 5 open πŸ—“οΈ 1 day ago
πŸ’Ύ kcp πŸ› Fix typo πŸ’¬ 3 open πŸ—“οΈ 3 days ago
πŸ’Ύ kcp :seedling: Proxy refactor to options/config/server pattern πŸ’¬ 7 open πŸ—“οΈ 4 days ago